Skip to content

Improve project structure - auto build tailwindcss css and js in build stage#401

Merged
jbampton merged 3 commits intoNextCommunity:mainfrom
MaxFork:max-updates-improve
Apr 3, 2026
Merged

Improve project structure - auto build tailwindcss css and js in build stage#401
jbampton merged 3 commits intoNextCommunity:mainfrom
MaxFork:max-updates-improve

Conversation

@BaseMax
Copy link
Copy Markdown
Member

@BaseMax BaseMax commented Apr 3, 2026

No description provided.

@BaseMax BaseMax requested a review from jbampton as a code owner April 3, 2026 12:58
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 3, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedesbuild@​0.25.12911007395100
Addednpm-run-all@​4.1.5991009875100
Addedpostcss-cli@​11.0.19910010082100
Addedpostcss@​8.5.8991008286100
Addedphaser@​3.90.0901001008480
Added@​tailwindcss/​postcss@​4.2.210010010097100

View full report

@jbampton jbampton self-assigned this Apr 3, 2026
@jbampton jbampton added the dependencies Pull requests that update a dependency file label Apr 3, 2026
@jbampton jbampton added this to Next Apr 3, 2026
@github-project-automation github-project-automation bot moved this to In progress in Next Apr 3, 2026
@jbampton jbampton added this to the Hackfest milestone Apr 3, 2026
@jbampton jbampton moved this from In progress to Review in progress in Next Apr 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Tailwind CSS and Phaser into the project's build pipeline using PostCSS and esbuild, replacing the previous CDN-based Tailwind setup. It includes updates to the project's dependencies, build scripts, and asset management. Feedback was provided regarding the start script in package.json, noting that running build tasks sequentially may cause unnecessary delays during development startup.

@jbampton
Copy link
Copy Markdown
Member

jbampton commented Apr 3, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a build pipeline for TailwindCSS and Phaser using PostCSS and esbuild, replaces the Tailwind CDN with a local bundle, and refactors several JavaScript files to use arrow functions and template literals. The review comments regarding the use of template literals were filtered out as they were general suggestions without actionable code blocks or specific style guide violations.

@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Next Apr 3, 2026
@jbampton jbampton merged commit 457f216 into NextCommunity:main Apr 3, 2026
4 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Next Apr 3, 2026
@jbampton
Copy link
Copy Markdown
Member

jbampton commented Apr 3, 2026

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants